fixes to email rendering by ahmetskilinc · Pull Request #1646 · Mail-0/Zero

ahmetskilinc · 2025-07-05T18:57:38Z

Description

fixes email padding and removed the title from the email preview

Summary by CodeRabbit

Style
- Added horizontal padding to the mail content area for improved layout.
Bug Fixes
- Enhanced email content sanitization by refining allowed HTML tags and attributes, and removing specific inline styles for cleaner display.

coderabbitai · 2025-07-05T18:57:45Z

Walkthrough

This update introduces horizontal padding to the mail content container in the frontend and modifies the backend email HTML sanitization to permit the <title> tag while removing it post-sanitization. No logic or control flow changes were made, and all public interfaces remain unchanged.

Changes

File(s)	Change Summary
apps/mail/components/mail/mail-content.tsx	Added horizontal padding (`px-4`) to the mail content container div.
apps/server/src/lib/email-processor.ts	Allowed the HTML `<title>` tag in the email HTML sanitization config, specified allowed attributes, removed `<title>` elements after sanitization, and removed `.gmail_quote` CSS rules from inline styles.

Possibly related PRs

new email renderer #1584: Introduced the MailContent component, which is directly modified in this PR and relates to the handling and display of mail content.

Suggested reviewers

MrgSub

Poem

In the land of code where emails dwell,
A rabbit hops with tales to tell—
Padding left and right, so neat,
And titles now in HTML greet.
With gentle paws and careful eye,
The mailbox feels just right—oh my!
🐇✉️

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between db3953a and 856d345.

📒 Files selected for processing (1)

apps/server/src/lib/email-processor.ts (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

apps/server/src/lib/email-processor.ts

⏰ Context from checks skipped due to timeout of 90000ms (2)

GitHub Check: Analyze (actions)
GitHub Check: Analyze (javascript-typescript)

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

ahmetskilinc · 2025-07-05T18:57:58Z

fixes to email rendering #1646 👈 (View in Graphite)
staging

This stack of pull requests is managed by Graphite. Learn more about stacking.

greptile-apps

PR Summary

Updates email rendering with padding adjustments and title tag handling in sanitization config.

Added padding (px-4) to email content container in apps/mail/components/mail/mail-content.tsx for improved visual presentation
Modified sanitization config in apps/server/src/lib/email-processor.ts to handle title tags in HTML emails

_{2 files reviewed, 2 comments}
_{Edit PR Review Bot Settings | Greptile}

apps/server/src/lib/email-processor.ts

ahmetskilinc · 2025-07-07T05:11:17Z

Merge activity

Jul 7, 5:11 AM UTC: @ahmetskilinc merged this pull request with Graphite.

fixes to email rendering

a9221d0

ahmetskilinc marked this pull request as ready for review July 5, 2025 18:59

graphite-app bot assigned ahmetskilinc Jul 5, 2025

greptile-apps bot reviewed Jul 5, 2025

View reviewed changes

apps/server/src/lib/email-processor.ts Show resolved Hide resolved

apps/server/src/lib/email-processor.ts Outdated Show resolved Hide resolved

graphite-app bot reviewed Jul 5, 2025

View reviewed changes

apps/server/src/lib/email-processor.ts Show resolved Hide resolved

ahmetskilinc added 2 commits July 5, 2025 20:11

removes title tag

db3953a

graphite recommendations

856d345

MrgSub approved these changes Jul 7, 2025

View reviewed changes

ahmetskilinc merged commit 8a17b37 into staging Jul 7, 2025
7 checks passed

ahmetskilinc deleted the 07-05-fixes_to_email_rendering branch July 7, 2025 05:11

coderabbitai bot mentioned this pull request Jul 7, 2025

fix: allow <style> and essential attributes in sanitizer #1648

Merged

coderabbitai bot mentioned this pull request Jul 23, 2025

fixes email styling #1813

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

fixes to email rendering#1646

fixes to email rendering#1646
ahmetskilinc merged 3 commits intostagingfrom
07-05-fixes_to_email_rendering

ahmetskilinc commented Jul 5, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jul 5, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

ahmetskilinc commented Jul 5, 2025

Uh oh!

greptile-apps bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ahmetskilinc commented Jul 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Comments

Conversation

ahmetskilinc commented Jul 5, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Suggested reviewers

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

ahmetskilinc commented Jul 5, 2025

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ahmetskilinc commented Jul 7, 2025

Merge activity

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ahmetskilinc commented Jul 5, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 5, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)